Stop piping child process output into logger only after close#29967
Merged
Stop piping child process output into logger only after close#29967
Conversation
ravicious
added
teleport-connect
ravicious
force-pushed
the
ravicious/child-logs
branch
2 times, most recently
from
d9f038f to
3c97d01
Compare
This ensures we stop logging only after both stdout and stderr close, not just either of them.
The previous implementation would log only the code.
ravicious
force-pushed
the
ravicious/child-logs
branch
from
3c97d01 to
79d678f
Compare
ryanclark
approved these changes
Aug 3, 2023
gzdunek
approved these changes
Aug 4, 2023
|
@ravicious See the table below for backport results.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While working on the agent cleanup daemon (#29896), I noticed that for some reason we don't log stderr of a forked Node.js process if it fails right after forking.
After some investigation, I realized that by default
sourceStream.pipe(destinationStream)closes the destination stream when the source stream closes.Because we piped into the Wintston instance stream both stdout and stderr of a child process, it was entirely possible for the stdout to get closed first. This would close the Winston stream, not giving stderr a chance to log any of the flushed output.
This PR fixes this by closing the Winston instance stream only after both stdout and stderr get closed (as signaled by the
closeevent).It also improves the logging of the
exitevent – the previous implementation didn't log the signal.